Code Action Testing #828
Merged
Code Action Testing #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Oct 27, 2021
jpogran
force-pushed
the
code-action-testing
branch
from
ada78b6 to
f525099
Compare
jpogran
force-pushed
the
code-action-testing
branch
3 times, most recently
from
be55045 to
fd66c2b
Compare
Closed
radeksimko
previously approved these changes
Nov 4, 2021
Standardize test runner by extracting duplicated invocation information and seperating the execution of terraform from the individual extension tests. Move integration tests to dedicated folder called `integration`. This organizes the tests and will allow UI specific tests in the future to be seperate from integration or unit tests. Remove explicit activation of extension and pausing to give time for extension to activate. This is already accomplished by our eactivation events. Add mocha chai library and update tests to properly teardown after execution. Add code action and completion tests to round out initial set of integration tests.
jpogran
force-pushed
the
code-action-testing
branch
from
fd66c2b to
266842b
Compare
radeksimko
approved these changes
Nov 4, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the code actions added in hashicorp/terraform-ls#680.
Moves the tests to the
suitefolder and separates them from the test harness files.Removes the activate method, which reduces overall test time by ~20-30 seconds. The activate method isn't needed because the extension is started in the
testFixturefolder, which has Terraform files that will trigger activation using our existingactivationEvents. This method also slept for 8000ms, which isn't necessary with recent LS releases.Needs hashicorp/terraform-ls#680 to merge