Extend jsx-a11y to also look for Next.js Images #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0308a62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RubenSandwich
commented
Mar 13, 2024
| @@ -69,6 +69,14 @@ module.exports = { | |||
| ], | |||
|
|
|||
| rules: { | |||
| // Extend jsx-a11y/alt-text to also look for Next.js Images | |||
| "jsx-a11y/alt-text": [2, { | |||
| "elements": ["img", "object", "area", "input[type=\"image\"]"], | |||
There was a problem hiding this comment.
Documentation wasn't clear if adding new elements could/would erase the current ones, so I added the defaults.
There was a problem hiding this comment.
This is a good call to be safe 👍
RubenSandwich
requested review from
a team and
EnMod
and removed request for
a team
EnMod
approved these changes
Mar 13, 2024
| @@ -69,6 +69,14 @@ module.exports = { | |||
| ], | |||
|
|
|||
| rules: { | |||
| // Extend jsx-a11y/alt-text to also look for Next.js Images | |||
| "jsx-a11y/alt-text": [2, { | |||
| "elements": ["img", "object", "area", "input[type=\"image\"]"], | |||
There was a problem hiding this comment.
This is a good call to be safe 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the jsx-a11y/alt-text rule to also look for Next.js Images.
PR Checklist 🚀