Export generic classes #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of this being considered for merging and releasing? |
|
I'm just a contributor as you are. I can't merge any pull request here. This should be safe to merge. |
edsko
force-pushed
the
edsko/export-generic-classes
branch
from
7127337 to
f13fedc
Compare
|
@tathougies any chance of this being merged? I've just rebased this on the most recent
|
`beam` relies very heavily on GHC generics, but the standard GHC generic instances are not appropriate for all use cases (motivating example in this case being [`large-records`](https://hackage.haskell.org/package/large-records)). Fortunately, the way GHC generics is set up allows us to use non-standard representations, _provided_ that we can then define additional instances for whatever generic classes are necessary. The [`beam-large-records`](https://github.com/well-typed/beam-large-records) library provides integration for `large-records` with `beam-core`, by providing these additional instances, but this does mean that the generic classes must be _exported_ from `beam-core` so that additional instances can be provided. This commit adds these exports.
edsko
force-pushed
the
edsko/export-generic-classes
branch
from
f13fedc to
57a12e6
Compare
|
Rebased this once more. Verified that all Anyone? |
I think @kmicklas is the one handling maintenance lately actually |
|
Hey new maintainer here, I can merge this and create a new release soon! |
|
Fantastic, thanks so much! |
|
This PR has been released in beam-core-0.10.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beamrelies very heavily on GHC generics, but the standard GHC generic instances are not appropriate for all use cases (motivating example in this case beinglarge-records). Fortunately, the way GHC generics is set up allows us to use non-standard representations, provided that we can then define additional instances for whatever generic classes are necessary. Thebeam-large-recordslibrary provides integration forlarge-recordswithbeam-core, by providing these additional instances, but this does mean that the generic classes must be exported frombeam-coreso that additional instances can be provided. This commit adds these exports.