Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose unsafeCreateUptoN' and createUptoN' #54

Closed
ndmitchell opened this issue Aug 21, 2015 · 0 comments · Fixed by #245
Closed

Expose unsafeCreateUptoN' and createUptoN' #54

ndmitchell opened this issue Aug 21, 2015 · 0 comments · Fixed by #245
Labels
enhancement low-hanging fruit
Milestone
0.10.12.0

Comments

@ndmitchell
Copy link

Data.ByteString.Internal implementsunsafeCreateUptoN' and createUptoN' but does not export them. These functions turned out to be useful for glguy/utf8-string#12. I see no reason to not export them from the internals.
@sjakobi sjakobi modified the milestone: 0.10.12.0 Jul 2, 2020
@sjakobi sjakobi added blocked: info-needed somebody needs to provide more information or investigate low-hanging fruit and removed low-hanging fruit blocked: info-needed somebody needs to provide more information or investigate labels Jul 4, 2020
@sjakobi sjakobi added this to the 0.10.12.0 milestone Jul 4, 2020
sjakobi added a commit that referenced this issue Jul 4, 2020
@sjakobi
Expose D.B.Internal.{create,unsafeCreate}UptoN'
ea5ce08 
Fixes #54.
@sjakobi sjakobi mentioned this issue Jul 4, 2020
Merged
sjakobi added a commit that referenced this issue Jul 17, 2020
@sjakobi
Expose D.B.Internal.{create,unsafeCreate}UptoN' (#245)
c866373 
Fixes #54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low-hanging fruit
Projects
None yet
Milestone
0.10.12.0
Development

Successfully merging a pull request may close this issue.

Expose D.B.Internal.{create,unsafeCreate}UptoN' haskell/bytestring
2 participants
@ndmitchell @sjakobi