Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.10.12.0 #257

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Prepare release 0.10.12.0 #257

merged 3 commits into from
Aug 6, 2020

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Aug 1, 2020

No description provided.

@sjakobi
Copy link
Member Author

sjakobi commented Aug 1, 2020

The changelog format is inspired by dhall's changelog. The link to the changelist is a suggestion from https://keepachangelog.com/en/1.0.0/.

If they get resolved in time, I would also like to include #255 and a fix for #256.

@sjakobi sjakobi mentioned this pull request Aug 1, 2020
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I can't spot anything significant missing from the git log.

@sjakobi sjakobi force-pushed the wip/sjakobi/0.10.12.0 branch from 6f567bc to 46d244c Compare August 1, 2020 19:13
@sjakobi
Copy link
Member Author

sjakobi commented Aug 1, 2020

Re-pushed since there had been some CI flakiness.

@@ -1,5 +1,5 @@
Name: bytestring
Version: 0.10.10.1
Version: 0.10.12.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it 0.10.12.0 and not 0.10.11.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply stuck with the existing scheme for the 0.10.* series to use only even numbers for the minor version components.

I don't know the reason for this scheme though. @dcoutts, could you help?

@sjakobi sjakobi merged commit e043aac into master Aug 6, 2020
@sjakobi sjakobi deleted the wip/sjakobi/0.10.12.0 branch August 6, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants