Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary comments. #369

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Remove unnecessary comments. #369

merged 2 commits into from
Feb 26, 2021

Conversation

kindaro
Copy link
Contributor

@kindaro kindaro commented Feb 26, 2021

@kindaro kindaro mentioned this pull request Feb 26, 2021
Merged
6 tasks
sjakobi
sjakobi reviewed Feb 26, 2021
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor request.

Data/ByteString.hs Outdated Show resolved Hide resolved
sjakobi
sjakobi approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! :)

@kindaro
Copy link
Contributor Author

kindaro commented Feb 26, 2021

Please help, I think a check needs to be restarted!

@sjakobi
Copy link
Member

sjakobi commented Feb 26, 2021

Please help, I think a check needs to be restarted!

I've restarted CI and created #370 to track this issue.

@kindaro
Copy link
Contributor Author

kindaro commented Feb 26, 2021

I think this is ready to be merged! My work here is done!

Only those with write access to this repository can merge pull requests.

@Bodigrim Bodigrim merged commit 416b719 into haskell:master Feb 26, 2021
@Bodigrim
Copy link
Contributor

Thanks!

@Bodigrim Bodigrim added this to the 0.11.2.0 milestone Feb 26, 2021
Bodigrim pushed a commit that referenced this pull request Mar 1, 2021
@kindaro @Bodigrim
Remove unnecessary comments. (#369)
9dc3c0e
noughtmare pushed a commit to noughtmare/bytestring that referenced this pull request Dec 12, 2021
@kindaro @noughtmare
Remove unnecessary comments. (haskell#369)
a63058a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kindaro @sjakobi @Bodigrim