-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ARM / M1 macOS in validate.sh
#10293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arguably we should be even more flexible, but I suspect that'll have to wait until we actually have people using e.g. risc-v (and, more importantly, CI resources for them).
Thank you! We'd welcome a contribution moving our Validate GitHub workflow to use arm runners that GitHub now provides. When they just appeared, our CI failed miserably, so we had to pin the intel runners. |
You're welcome! Is there anything I need to do to get this merged? |
This PR is ready; you need only set the label and Mergify will do the rest. Since it's only one commit, there's no practical difference between the "merge me" and "squash+merge me" labels. (Mergify will wait two days to merge it, to allow for last minute comments or updates which will restart the timer.) |
@geekosaur I'm not a maintainer so I don't have permissions to edit PR labels, even my own. |
Label set. |
@9999years: Thank you for the PR. I've invited you to the repo. If the Triage role is not enough to set labels, please let me know (but it should be IIRC). |
It is, per GitHub's description of the roles here (not sure this is accessible to non-admins though, since it's under repository settings). |
@Mikolaj Thank you, that'll make it easier for me in the future! |
ff623ec
to
60cae7f
Compare
Previously,
validate.sh
would assume that all non-Linux and non-Windows builds were x86_64 macOS. ARM64 macOS and Linux machines (and, to an extent, Windows machines) are now quite common. The test suite should work with them.