Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM / M1 macOS in validate.sh #10293

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

9999years
Copy link
Collaborator

Previously, validate.sh would assume that all non-Linux and non-Windows builds were x86_64 macOS. ARM64 macOS and Linux machines (and, to an extent, Windows machines) are now quite common. The test suite should work with them.

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably we should be even more flexible, but I suspect that'll have to wait until we actually have people using e.g. risc-v (and, more importantly, CI resources for them).

@ulysses4ever
Copy link
Collaborator

Thank you! We'd welcome a contribution moving our Validate GitHub workflow to use arm runners that GitHub now provides. When they just appeared, our CI failed miserably, so we had to pin the intel runners.

@9999years
Copy link
Collaborator Author

You're welcome! Is there anything I need to do to get this merged?

@geekosaur
Copy link
Collaborator

geekosaur commented Aug 31, 2024

This PR is ready; you need only set the label and Mergify will do the rest. Since it's only one commit, there's no practical difference between the "merge me" and "squash+merge me" labels.

(Mergify will wait two days to merge it, to allow for last minute comments or updates which will restart the timer.)

@geekosaur
Copy link
Collaborator

If you do decide to take on the M1 runner problem, you'll want to look over #9949 and #9948 for the issues we ran in to that caused us to force the Intel runners. Hopefully most of those problems have been resolved in recent versions of the macos-14 image. But that should be a separate PR.

@9999years
Copy link
Collaborator Author

@geekosaur I'm not a maintainer so I don't have permissions to edit PR labels, even my own.

@geekosaur geekosaur added the merge me Tell Mergify Bot to merge label Sep 3, 2024
@geekosaur
Copy link
Collaborator

Label set.

@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 3, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Sep 4, 2024

@geekosaur I'm not a maintainer so I don't have permissions to edit PR labels, even my own.

@9999years: Thank you for the PR. I've invited you to the repo. If the Triage role is not enough to set labels, please let me know (but it should be IIRC).

@geekosaur
Copy link
Collaborator

It is, per GitHub's description of the roles here (not sure this is accessible to non-admins though, since it's under repository settings).

@9999years
Copy link
Collaborator Author

@Mikolaj Thank you, that'll make it easier for me in the future!

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Sep 5, 2024
@mergify mergify bot merged commit d57001a into haskell:master Sep 5, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants