Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsequent Cabal Exceptions #9143

Conversation

SuganyaAK
Copy link
Collaborator

@SuganyaAK SuganyaAK commented Jul 24, 2023

The die' calls are modified to throw Cabal Exceptions in few more modules followed by #PR-9018 which is merged.

Once the cabal exception is thrown and captured , the rendering of the error code and error message(along with the metadata) is done at the display time of the exception.
After accepting the new error output, the error messages are shown with error codes prepended as seen in the out files.

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies cabal behaviour

Include the following checklist in your PR:

Bonus points for added automated tests!


Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

Cabal/src/Distribution/Simple/BuildTarget.hs Outdated Show resolved Hide resolved
@SuganyaAK SuganyaAK marked this pull request as ready for review July 26, 2023 01:35
@gbaz gbaz added the squash+merge me Tell Mergify Bot to squash-merge label Jul 31, 2023
Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 2, 2023
@mergify mergify bot merged commit 0e8f2cd into haskell:master Aug 2, 2023
@SuganyaAK SuganyaAK mentioned this pull request Aug 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants