-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsequent Cabal Exceptions #9143
Merged
mergify
merged 9 commits into
haskell:master
from
SuganyaAK:Cabal-Error-Refactor--Subsequent-Cabal-Exceptions
Aug 2, 2023
Merged
Subsequent Cabal Exceptions #9143
mergify
merged 9 commits into
haskell:master
from
SuganyaAK:Cabal-Error-Refactor--Subsequent-Cabal-Exceptions
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jul 24, 2023
…s", "UnknownBuildTarget", "AmbiguousBuildTarget"
gbaz
approved these changes
Jul 31, 2023
Kleidukos
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge delay passed
Applied (usually by Mergify) when PR approved and received no updates for 2 days
squash+merge me
Tell Mergify Bot to squash-merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
die'
calls are modified to throw Cabal Exceptions in few more modules followed by #PR-9018 which is merged.Once the cabal exception is thrown and captured , the rendering of the error code and error message(along with the metadata) is done at the display time of the exception.
After accepting the new error output, the error messages are shown with error codes prepended as seen in the out files.
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies
cabal
behaviourInclude the following checklist in your PR:
Bonus points for added automated tests!
Template Β: This PR does not modify
cabal
behaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: