You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get that there are many colourable panels on the bikeshed that is cabal env, and even many real engineering choices and challenges, but it would be very nice if at least the user gets some warning if they cabal install --lib and that creates an environment file. After all, statistically, this is not what they intended, or if it was they probably didn't know the consequences. Had they known the consequences, they would have realised that this is not what they wanted.
This patch only shows a warning if an environment file does not yet exist, to acknowledge the set of people who are actually using this functionality.
🛑 The pull request has been removed from the queue default
Pull request #9895 has been dequeued by a dequeue command.
You can take a look at Queue: Embarked in merge queue check runs for more details.
In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.
* Add a warning when an env file is created
#6481 (comment)
* Formatting
* Improve wording of warning message
* Only show warning if --package-env not given
* Improve message and its formatting
* Formatting
(cherry picked from commit 00ce024)
It looks like, Mergify is ready to take it once Validate succeeds.
Validate did succeed, but I think the PR was not the first in the queue, so mergify waited, another got merged and indeed validate had to run again due to a rebase. This is fine.
backportmerge delay passedApplied (usually by Mergify) when PR approved and received no updates for 2 daysmerge meTell Mergify Bot to merge
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Mikolaj
force-pushed
the
mergify/bp/3.12/pr-9705
branch
from
mergify
bot
added
the
merge delay passed
Inspired by #6481 (comment)
I get that there are many colourable panels on the bikeshed that is
cabal env, and even many real engineering choices and challenges, but it would be very nice if at least the user gets some warning if theycabal install --liband that creates an environment file. After all, statistically, this is not what they intended, or if it was they probably didn't know the consequences. Had they known the consequences, they would have realised that this is not what they wanted.This patch only shows a warning if an environment file does not yet exist, to acknowledge the set of people who are actually using this functionality.
This is blocked on the bug mentioned here: #9697 (comment)
This is an automatic backport of pull request #9705 done by [Mergify](https://mergify.com).