Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Specify component types in detailed deps page #1280

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Jan 1, 2024

With the advent of multiple sublibraries per
package, it has become less clear what each
component is, on the 'detailed dependencies'
page.

This changeset replaces the tabulated view of

component name list of dependencies
- lib 1 - dep 1
- dep 2
- exe 1 - dep 3

With the more heirarchical:

Libraries

  • lib 1
    • dep 1
    • dep 2 ...

Executables

  • exe 1
    • dep 3

This change is related to #1218


Screenshots

Before

Screenshot from 2024-01-01 23-04-03

After

Screenshot from 2024-01-01 23-01-48

Obviously, when there are no components of a given type ({Executables, Libraries}), the header itself is not rendered.

With the advent of multiple sublibraries per
package, it has become less clear what each
component is, on the 'detailed dependencies'
page.

This changeset replaces the tabulated view of

| component name | list of dependencies |
| -------------- | -------------------- |
| - lib 1        | - dep 1              |
|                | - dep 2              |
|                |                      |
| - exe 1        | - dep 3              |

With the more heirarchical:

Libraries
  - lib 1
    - dep 1
    - dep 2
  ...

Executables
  - exe 1
    - dep 3

This change is related to haskell#1218
@ysangkok ysangkok merged commit 4796040 into haskell:master Sep 8, 2024
10 checks passed
@ysangkok
Copy link
Member

ysangkok commented Sep 8, 2024

Thank you, this seems useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants