This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Do not traverse into Generated bindings when creating TypeMap #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
typemap-performance
branch
2 times, most recently
from
1a1c9f4 to
f639484
Compare
fendor
force-pushed
the
typemap-performance
branch
from
f639484 to
b14a3f8
Compare
fendor
force-pushed
the
typemap-performance
branch
from
f65f854 to
f614c59
Compare
|
Looks good to me. Even if the patch isn't perfect, at least for now this reduces memory usage a lot of modules with a lot of derived code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from mpickering@13daf07 by cherry-picking.