Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Handling Windows specific delimiters in func tests #1400

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Handling Windows specific delimiters in func tests #1400

merged 1 commit into from
Oct 1, 2019

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 1, 2019

@jneira jneira requested a review from fendor October 1, 2019 06:56
@fendor fendor merged commit 5385087 into haskell:master Oct 1, 2019
@jneira jneira deleted the fix-win-imports branch October 1, 2019 09:01
alanz
alanz reviewed Oct 5, 2019
View reviewed changes
test/functional/FunctionalCodeActionsSpec.hs
Comment on lines +224 to +228
let prefixes = [ "Could not load module `Data.Text'" -- Windows && GHC >= 8.6
, "Could not find module `Data.Text'" -- Windows
, "Could not load module ‘Data.Text’" -- GHC >= 8.6
, "Could not find module ‘Data.Text’"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have some uniform way of dealing with the set of quotes? Perhaps run the expected string through a normaliser and then match on the result?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alanz alanz alanz left review comments

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in windows detected by the functional test suite
3 participants
@jneira @alanz @fendor