This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 207
Various improvements and fixes over shake install #1452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-engine into improve-install
fendor
suggested changes
Nov 14, 2019
Anrock
reviewed
Nov 15, 2019
Anrock
reviewed
Nov 15, 2019
fendor
suggested changes
Nov 16, 2019
samuelpilz
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes. The upgrade of the documentation is a big bonus
fendor
approved these changes
Nov 19, 2019
thanks all for the feedback! azure ci seems to be happy too so merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Use explicit list of ghc supported versions to filter out targets (stack and cabal).build-lastest
to build hie with the lastest supported and available ghcbuild
target to build the lastest version and data files insteadbuild-all
Prints a warning about consumed resources and time when executingbuild-all
and when printing the helpbuild-all
target (see Various improvements and fixes over shake install #1452 (comment))Bug fixes
cabal-ghcs
work in windowscabal v2-install
phase ofcabal-hie-<version>
targetstack-install-cabal
target for posix envs. Hopefully it fixes stack ./install.hs stack-install-cabal failed #1436Unrelated changes