Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Update README.md #1459

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Update README.md #1459

merged 3 commits into from
Nov 20, 2019

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Nov 18, 2019

The windows pre-requirements are not optional but an absolute must when cloning. Well if you already have the right settings it will be a no-op just like installing sudo apt install libicu-dev libtinfo-dev libgmp-dev on linux will be a no-op when you already have them.

Setting the windows path limitation was not enough. Git also needs to be configured.

The windows pre-requirements are not optional but an absolute must when cloning. Well if you already have the right settings it will be a no-op just like installing `sudo apt install libicu-dev libtinfo-dev libgmp-dev` on linux will be a no-op when you already have them.

Setting the windows path limitation was not enough. Git also needs to be configured.
@Anrock
Copy link
Collaborator

Anrock commented Nov 18, 2019

The windows pre-requirements are not optional but an absolute must when cloning.

Objection. I never did any of described and never had any problems with paths.

@flip111
Copy link
Contributor Author

flip111 commented Nov 18, 2019

@Anrock like i said. I could say "objection i never had to install the requirements for linux" https://github.com/haskell/haskell-ide-engine#linux-specific-pre-requirements

because i already had them ?!

So depending on your situation you already applied option 1 or 2 otherwise it's not possible.

@fendor fendor requested review from jneira and Anrock November 18, 2019 14:45
@Anrock
Copy link
Collaborator

Anrock commented Nov 18, 2019

Gonna check if I really had this options enabled on my Windows box this week.

@nponeccop
Copy link
Contributor

nponeccop commented Nov 19, 2019

Setting the windows path limitation was not enough.

The Windows path limitation was optional last time I checked. It is configuration-dependent: the user should either ensure that there are no long paths or change a system-wide configuration. The latter is undesirable and/or impossible in controlled environments.

So we should test if it works when cloned into c:\a or if other workarounds such as subst work. If they don't then we should say it's mandatory and sorry for those who can't change. But as long as it works it's not a good idea to request long paths unconditionally.

Upd: I finally read the actual diff, and I like it!

@jneira
Copy link
Member

jneira commented Nov 19, 2019

Hi, @flip111 thanks for your proposal, with which I agree in general. However i want to clarify some points:

  • Agree in removing optional but the suggestion already was not technically precise: you can place the project in a path short enough to avoid the issue but it has not be root. I myself have D:\dev\ws\haskell\haskell-ide-engine without long paths enabled and it works fine. So there is a threshold and optional tried to capture badly that fact imo.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
update after comments
@jneira
Copy link
Member

jneira commented Nov 20, 2019

@flip111 sorry for spread request changes which are concerns over the original text and no your concrete changes (they improve strictly the original text)
So if you want to merge it as is i'll approve it (we can later make it more precise). Of course if you want to address (or discuss or whatever) them it would be fine too.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Javier Neira  <[email protected]>
@flip111
Copy link
Contributor Author

flip111 commented Nov 20, 2019

yes please approve & merge if you think it's an improvement to the current situation

@jneira
Copy link
Member

jneira commented Nov 20, 2019

thanks! merging

@jneira jneira merged commit a597236 into haskell:master Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants