-
Notifications
You must be signed in to change notification settings - Fork 206
Conversation
The windows pre-requirements are not optional but an absolute must when cloning. Well if you already have the right settings it will be a no-op just like installing `sudo apt install libicu-dev libtinfo-dev libgmp-dev` on linux will be a no-op when you already have them. Setting the windows path limitation was not enough. Git also needs to be configured.
Objection. I never did any of described and never had any problems with paths. |
@Anrock like i said. I could say "objection i never had to install the requirements for linux" https://github.com/haskell/haskell-ide-engine#linux-specific-pre-requirements because i already had them ?! So depending on your situation you already applied option 1 or 2 otherwise it's not possible. |
Gonna check if I really had this options enabled on my Windows box this week. |
The Windows path limitation was optional last time I checked. It is configuration-dependent: the user should either ensure that there are no long paths or change a system-wide configuration. The latter is undesirable and/or impossible in controlled environments. So we should test if it works when cloned into c:\a or if other workarounds such as Upd: I finally read the actual diff, and I like it! |
Hi, @flip111 thanks for your proposal, with which I agree in general. However i want to clarify some points:
|
update after comments
@flip111 sorry for spread request changes which are concerns over the original text and no your concrete changes (they improve strictly the original text) |
Co-Authored-By: Javier Neira <[email protected]>
yes please approve & merge if you think it's an improvement to the current situation |
thanks! merging |
The windows pre-requirements are not optional but an absolute must when cloning. Well if you already have the right settings it will be a no-op just like installing
sudo apt install libicu-dev libtinfo-dev libgmp-dev
on linux will be a no-op when you already have them.Setting the windows path limitation was not enough. Git also needs to be configured.