-
Notifications
You must be signed in to change notification settings - Fork 207
First pass at printing out debug info if started without --lsp #1538
Conversation
Example output Running HIE(hie) Version 1.0.0.0, Git revision 666626e (dirty) (3534 commits) x86_64 ghc-8.6.5 Current directory:/home/alanz/mysrc/github/alanz/haskell-ide-engine/app args:[] Looking for project config cradle... 2020-01-01 22:41:46.396914848 [ThreadId 4] - Cabal-Helper dirs: ["/home/alanz/mysrc/github/alanz/haskell-ide-engine","/home/alanz/mysrc/github/alanz/haskell-ide-engine/app/File.hs"] Resolving dependencies... Build profile: -w ghc-8.6.5 -O1 In order, the following would be built (use -v for more details): - hie-plugin-api-0.14.0.0 (lib) (configuration changed) - haskell-ide-engine-1.0.0.0 (lib) (configuration changed) - haskell-ide-engine-1.0.0.0 (test:wrapper-test) (configuration changed) - haskell-ide-engine-1.0.0.0 (exe:hie-wrapper) (configuration changed) - haskell-ide-engine-1.0.0.0 (lib:hie-test-utils) (configuration changed) - haskell-ide-engine-1.0.0.0 (exe:hie) (configuration changed) - haskell-ide-engine-1.0.0.0 (test:unit-test) (configuration changed) - haskell-ide-engine-1.0.0.0 (test:plugin-dispatcher-test) (configuration changed) - haskell-ide-engine-1.0.0.0 (test:dispatcher-test) (configuration changed) - haskell-ide-engine-1.0.0.0 (test:func-test) (configuration changed) Cradle:Cabal project
Since it is needed once more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than being the default option when no arguments are passed, should this maybe instead be another flag like --simulate
? I'm just wary that most other language servers do not take in another argument. I think LSP mode should probably be the default since it allows people to configure their clients by setting only the language server executable without any arguments
@bubba Perhaps, but until very recently (and not yet in a tagged release) we have always used the "--lsp" flag. Also, this mimics what |
@alanz We will need to update the README and vscode-hie-server for this, they currently do not contain the --lsp flag |
Should we undo this then, or change the flags as @bubba suggested? |
@fendor I updated the vscode client to include the --lsp flag again, I think we should let this stand, for now. |
What about the other clients? Should update them somehow, too? |
To my knowledge vscode and emacs-lsp are updated. Not sure what others need it, we should see reports if it is a problem. Luckily it is just a few days within a release, so they should be supporting the non-master stuff too. Maybe. |
Closes #1412
Example output