Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Allow newer optparse-applicative for ormolu (stack version) #1586

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 21, 2020

@jneira jneira requested a review from Avi-D-coder January 21, 2020 20:52
Copy link
Collaborator

@Avi-D-coder Avi-D-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we have tried to avoid allow newer, but this is simpler than the git package approach, so it's a thumbs up from me.

@alanz
Copy link
Collaborator

alanz commented Jan 21, 2020

Is it only a big switch in stack? No finer grain possibility?

@Avi-D-coder
Copy link
Collaborator

@alanz As far as I know there is no fine grain support.

@jneira
Copy link
Member Author

jneira commented Jan 22, 2020

Linux job for stack-8.8.1.yaml is failing with:

haskell-ide-engine> /home/vsts/work/1/s/src/Haskell/Ide/Engine/Plugin/Ormolu.hs:15:1: error: [-Wunused-imports, -Werror=unused-imports]
haskell-ide-engine>     The import of ‘Ormolu.Config’ is redundant
haskell-ide-engine>       except perhaps to import instances from ‘Ormolu.Config’
haskell-ide-engine>     To import instances alone, use: import Ormolu.Config()
haskell-ide-engine>    |
haskell-ide-engine> 15 | import Ormolu.Config (defaultConfig)
haskell-ide-engine>    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
haskell-ide-engine> 
haskell-ide-engine> /home/vsts/work/1/s/src/Haskell/Ide/Engine/Plugin/Ormolu.hs:16:1: error: [-Wunused-imports, -Werror=unused-imports]
haskell-ide-engine>     The import of ‘Ormolu.Exception’ is redundant
haskell-ide-engine>       except perhaps to import instances from ‘Ormolu.Exception’
haskell-ide-engine>     To import instances alone, use: import Ormolu.Exception()
haskell-ide-engine>    |
haskell-ide-engine> 16 | import Ormolu.Exception (OrmoluException)
haskell-ide-engine>    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Completed 2 action(s).

It seems there is no job in circleci for stack-8.8.1 yet.

@jneira
Copy link
Member Author

jneira commented Jan 22, 2020

well this is needed to even build it, so merge

@jneira jneira merged commit dbbaf4d into haskell:master Jan 22, 2020
@jneira jneira deleted the ormolu-allow-newer-stack branch January 23, 2020 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants