This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Demote HsImport func-tests to unit-test #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanz
approved these changes
Jan 22, 2020
Avi-D-coder
approved these changes
Jan 22, 2020
fendor
force-pushed
the
fendor/demote-hsimport-to-unit-tests
branch
2 times, most recently
from
1516a17 to
2c33e49
Compare
|
The speedup is very relative, depending on how much needs to be rebuild, but there is a consistent speed up, at least it takes only 75% of the previous test-runs. |
Previously, we had long running func-tests for HsImport. However, after the first code-action tests, we actually are testing the same functionality over and over again. Moreover, we dont have to test that HsImport works as intended since they have a huge set of tests, anyways. Now, we only test that our implementation of the plugin truly maps correctly to HsImport, accelerating execution time of func-tests as a side-effect. Hooray!
fendor
force-pushed
the
fendor/demote-hsimport-to-unit-tests
branch
from
149c0c7 to
b27b5b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had long running func-tests for HsImport.
However, after the first code-action tests, we actually are
testing the same functionality over and over again.
Moreover, we dont have to test that HsImport works as intended
since they have a huge set of tests, anyways.
Now, we only test that our implementation of the plugin
truly maps correctly to HsImport, accelerating execution time
of func-tests as a side-effect. Hooray!
Part of #1585