This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Report progress as a percentage #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was displayed as a value from 0% to 1% As specified https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workDoneProgress See also https://github.com/alanz/haskell-lsp/blob/1f85ef3c150dc8b2626a181c47d8635015e67ee5/src/Language/Haskell/LSP/Core.hs#L150-L154
jneira
approved these changes
Mar 11, 2020
fendor
approved these changes
Mar 11, 2020
|
Thanks!
…On Wed, Mar 11, 2020 at 10:17 PM fendor ***@***.***> wrote:
Merged #1692 <#1692>
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1692 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXB3RUIYZASKR3J5ILLRG6MPRANCNFSM4LFO4GKA>
.
|
|
Thank you for this sensible pull request :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was displayed as a value from 0% to 1%
As specified https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workDoneProgress
See also https://github.com/alanz/haskell-lsp/blob/1f85ef3c150dc8b2626a181c47d8635015e67ee5/src/Language/Haskell/LSP/Core.hs#L150-L154