Skip to content

Commit

Permalink
Shut the Shake session on exit, instead of restarting it (#1655)
Browse files Browse the repository at this point in the history
Restarting the session will result in progress reporting and other messages
being sent to the client, which might have already closed the stream

Co-authored-by: Potato Hatsue <[email protected]>
  • Loading branch information
pepeiborra and berberman authored Apr 3, 2021
1 parent 246c439 commit 252c500
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ghcide/src/Development/IDE/LSP/LanguageServer.hs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ exitHandler :: IO () -> LSP.Handlers (ServerM c)
exitHandler exit = LSP.notificationHandler SExit $ const $ do
(_, ide) <- ask
-- flush out the Shake session to record a Shake profile if applicable
liftIO $ restartShakeSession (shakeExtras ide) []
liftIO $ shakeShut ide
liftIO exit

modifyOptions :: LSP.Options -> LSP.Options
Expand Down

0 comments on commit 252c500

Please sign in to comment.