Merge branch 'master' into reimplement-shake

haskell · Sep 24, 2021 · 4d52c5c · 4d52c5c
2 parents 7e130e1 + c419b37
commit 4d52c5c
Show file tree

Hide file tree

Showing 5 changed files with 94 additions and 26 deletions.
diff --git a/docs/index.rst b/docs/index.rst
@@ -1,14 +1,14 @@
 haskell-language-server
 =======================
 
-Integration point for `ghcide <https://github.com/haskell/ghcide>`_ and `haskell-ide-engine <https://github.com/haskell/haskell-ide-engine>`_. One IDE to rule
-them all. Read the `project's background <https://neilmitchell.blogspot.com/2020/01/one-haskell-ide-to-rule-them-all.html>`_.
+Official haskell ide support via language server (LSP). Successor of `ghcide <https://github.com/haskell/ghcide>`_ and `haskell-ide-engine <https://github.com/haskell/haskell-ide-engine>`_. Read the `project's background <https://neilmitchell.blogspot.com/2020/01/one-haskell-ide-to-rule-them-all.html>`_.
 
 .. toctree::
    :maxdepth: 2
 
    features
    installation
+   supported-versions
    configuration
    troubleshooting
    contributing/index
diff --git a/docs/installation.md b/docs/installation.md
@@ -218,3 +218,4 @@ brew install haskell-language-server
 This formula contains HLS binaries compiled with GHC versions available via Homebrew; at the moment those are: 8.6.5, 8.8.4, 8.10.7.
 
 You need to provide your own GHC/Cabal/Stack as required by your project, possibly via Homebrew.
+
diff --git a/docs/supported-versions.md b/docs/supported-versions.md
@@ -0,0 +1,72 @@
+# Supported GHC versions
+
+## Current GHC version support status
+
+The current support for different GHC versions is given in the following table.
+
+| GHC version | Last supporting HLS version                                                                                                                              | Deprecation status                       |
+| ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------- |
+| 9.2.0       | not supported yet                                                                                                                                        |                                          |
+| 9.0.1       | [current](https://github.com/haskell/haskell-language-server/releases/latest) ([partial](https://github.com/haskell/haskell-language-server/issues/297)) |                                          |
+| 8.10.7      | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            |                                          |
+| 8.10.6      | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            | will be deprecated after LTS and HLS full support for ghc-9.0 |
+| 8.10.5      | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            | deprecated, will be removed after 1.5.0  |
+| 8.10.4      | [1.4.0](https://github.com/haskell/haskell-language-server/releases/tag/1.4.0)                                                                           | deprecated                               |
+| 8.10.3      | [1.4.0](https://github.com/haskell/haskell-language-server/releases/tag/1.4.0)                                                                           | deprecated                               |
+| 8.10.2      | [1.4.0](https://github.com/haskell/haskell-language-server/releases/tag/1.4.0)                                                                           | deprecated                               |
+| 8.10.1      | [0.9.0](https://github.com/haskell/haskell-language-server/releases/tag/0.9.0)                                                                           | deprecated                               |
+| 8.8.4       | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            | will be deprecated after LTS and HLS full support for ghc-9.2 |
+| 8.8.3       | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            | deprecated, will be removed after 1.5.0  |
+| 8.8.2       | [1.2.0](https://github.com/haskell/haskell-language-server/releases/tag/1.2.0)                                                                           | deprecated                               |
+| 8.6.5       | [current](https://github.com/haskell/haskell-language-server/releases/latest)                                                                            | will be deprecated after LTS and HLS full suppot for ghc-9.2 |
+| 8.6.4       | [1.4.0](https://github.com/haskell/haskell-language-server/releases/tag/1.4.0)                                                                           | deprecated                               |
+
+GHC versions not in the list have never been supported by HLS, or are not planned. LTS stands for [Stackage](https://www.stackage.org/) Long Term Support.
+
+The policy for when we deprecate support for versions of GHC is given below. The table reflects that, but we may decide to deviate from it for good reasons.
+
+### Using deprecated GHC versions
+
+Users who want to use a GHC version which is not supported by the latest HLS can still use older versions of HLS (consult the version support table above to identify the appropriate HLS version).
+In the future, we may extend the existing discovery mechanisms (`haskell-language-server-wrapper`, automatic download in vscode extension) to find and download older HLS binaries in this case.
+
+Users of a deprecated minor version (where the major version is still supported) can try building the latest HLS from source, which will likely still work, since the GHC API tends to remain compatible across minor versions.
+
+## GHC version deprecation policy
+
+### Major versions
+
+A major GHC version is a "legacy" version if it is 3 or more major versions behind the GHC version used in the newest Stackage LTS.
+
+HLS will support all non-legacy major versions of GHC.
+
+### Minor versions
+
+For the latest supported major GHC version we will support at least 2 minor versions.
+
+For the rest of the supported major GHC versions, we will support at least the latest minor version in Stackage LTS (so 1 minor version).
+
+### Announcements
+
+We will warn users about the upcoming deprecation of a GHC version in the notes of the release *prior* to the deprecation itself.
+
+### Why deprecate older versions of GHC?
+
+`haskell-language-server`(HLS) is highly tied to the ghc api.This imposes a high maintenance cost:
+
+- The codebase is littered with conditional logic,
+- We own auxiliary packages to support older versions of ghc.
+- CI has to cover all the supported versions.
+
+So we need to limit the ghc support to save maintainers and contributors time and reduce CI resources.
+
+At same time we aim to support the right balance of ghc versions to minimize impact to final users.
+
+### What factors do we take into account when deprecating a version?
+
+To establish and apply the policy we take into account:
+
+- Completeness: support includes all plugins and features
+- The most recent [stackage](https://www.stackage.org/) LTS snapshot
+- The GHC versions used in the most popular [linux distributions](https://repology.org/project/ghc/versions)
+- The reliability of different ghc versions on the major operating systems (Linux, Windows, MacOS)
diff --git a/ghcide/ghcide.cabal b/ghcide/ghcide.cabal
@@ -2,7 +2,7 @@ cabal-version:      2.4
 build-type:         Simple
 category:           Development
 name:               ghcide
-version:            1.4.2.1
+version:            1.4.2.2
 license:            Apache-2.0
 license-file:       LICENSE
 author:             Digital Asset and Ghcide contributors

diff --git a/ghcide/src/Development/IDE/GHC/Compat/Units.hs b/ghcide/src/Development/IDE/GHC/Compat/Units.hs
@@ -49,46 +49,41 @@ module Development.IDE.GHC.Compat.Units (
 
 #if MIN_VERSION_ghc(9,0,0)
 #if MIN_VERSION_ghc(9,2,0)
-import qualified GHC.Data.ShortText             as ST
-import           GHC.Driver.Env                 (hsc_unit_dbs)
+import qualified GHC.Data.ShortText              as ST
+import           GHC.Driver.Env                  (hsc_unit_dbs)
 import           GHC.Unit.Env
 import           GHC.Unit.External
 #else
 import           GHC.Driver.Types
 #endif
 import           GHC.Data.FastString
-import           GHC.Driver.Session             (PackageArg (..),
-                                                 PackageFlag (..))
-import qualified GHC.Driver.Session             as DynFlags
+import qualified GHC.Driver.Session              as DynFlags
 import           GHC.Types.Unique.Set
-import qualified GHC.Unit.Info                  as UnitInfo
-import           GHC.Unit.Module.Name           (ModuleName)
-import           GHC.Unit.State                 (LookupResult, PackageName,
-                                                 UnitInfo,
-                                                 UnitState (unitInfoMap))
-import qualified GHC.Unit.State                 as State
-import           GHC.Unit.Types                 hiding (moduleUnit, toUnitId)
-import qualified GHC.Unit.Types                 as Unit
+import qualified GHC.Unit.Info                   as UnitInfo
+import           GHC.Unit.State                  (LookupResult, UnitInfo,
+                                                  UnitState (unitInfoMap))
+import qualified GHC.Unit.State                  as State
+import           GHC.Unit.Types                  hiding (moduleUnit, toUnitId)
+import qualified GHC.Unit.Types                  as Unit
 #else
-import           DynFlags                       (PackageArg (..),
-                                                 PackageFlag (..))
 import qualified DynFlags
 import           FastString
 import           HscTypes
-import           Module                         hiding (moduleUnitId)
+import           Module                          hiding (moduleUnitId)
 import qualified Module
-import           Packages                       (InstalledPackageInfo (haddockInterfaces, packageName),
-                                                 LookupResult, PackageConfig,
-                                                 PackageConfigMap, PackageName,
-                                                 PackageState,
-                                                 getPackageConfigMap,
-                                                 lookupPackage')
+import           Packages                        (InstalledPackageInfo (haddockInterfaces, packageName),
+                                                  LookupResult, PackageConfig,
+                                                  PackageConfigMap,
+                                                  PackageState,
+                                                  getPackageConfigMap,
+                                                  lookupPackage')
 import qualified Packages
 #endif
 
+import           Development.IDE.GHC.Compat.Core
 import           Development.IDE.GHC.Compat.Env
 #if MIN_VERSION_ghc(9,0,0) && !MIN_VERSION_ghc(9,2,0)
-import           Data.Map                       (Map)
+import           Data.Map                        (Map)
 #endif
 import           Data.Either
 import           Data.Version
Original file line number	Diff line number	Diff line change
Expand Up		@@ -218,3 +218,4 @@ brew install haskell-language-server
		This formula contains HLS binaries compiled with GHC versions available via Homebrew; at the moment those are: 8.6.5, 8.8.4, 8.10.7.

		You need to provide your own GHC/Cabal/Stack as required by your project, possibly via Homebrew.