Skip to content

Commit

Permalink
clean up references to cabal-ghc92.project and other stale docs
Browse files Browse the repository at this point in the history
  • Loading branch information
pepeiborra committed May 2, 2022
1 parent e74f6d8 commit cf05dee
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ variables:
- GHC_VERSION: 9.0.2
CABAL_PROJECT: cabal.project
- GHC_VERSION: 9.2.2
CABAL_PROJECT: cabal-ghc92.project
CABAL_PROJECT: cabal.project
- GHC_VERSION: 9.2.1
CABAL_PROJECT: cabal-ghc92.project
CABAL_PROJECT: cabal.project

workflow:
rules:
Expand Down
4 changes: 2 additions & 2 deletions bindist/ghcs
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
8.8.4,cabal.project
8.10.7,cabal.project
9.0.2,cabal.project
9.2.1,cabal-ghc92.project
9.2.2,cabal-ghc92.project
9.2.1,cabal.project
9.2.2,cabal.project
4 changes: 2 additions & 2 deletions bindist/ghcs-Msys
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
8.10.7,cabal.project
9.0.2,cabal.project
9.2.2,cabal-ghc92.project
9.2.1,cabal-ghc92.project
9.2.2,cabal.project
9.2.1,cabal.project
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ghcup compile hls -v 1.6.1.0 --ghc 8.10.7 --ghc 8.8.4

Use a different `cabal.project` for a GHC version:
```
ghcup compile hls -v 1.6.1.0 --ghc 9.2.1 --cabal-project cabal-ghc92.project
ghcup compile hls -v 1.6.1.0 --ghc 9.2.1 --cabal-project cabal.project
```

Check `ghcup compile hls --help` for a full list of compilation options.
Expand Down
14 changes: 1 addition & 13 deletions docs/troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,16 +171,10 @@ The easiest way to obtain a dynamically linked HLS binary is to build HLS locall
cabal update && cabal install :pkg:haskell-language-server
```

If you are compiling with a ghc version with a specific `cabal-ghc${ghcVersion}.project` in the repo you will have to use it. For example for ghc-9.0.x:

```bash
cabal update && cabal install pkg:haskell-language-server
```

Or with `stack`:

```bash
stack install haskell-language-server --stack-yaml=stack-${ghcVersion}.yaml
stack install haskell-language-server
```

You also can leverage `ghcup compile hls`:
Expand All @@ -189,12 +183,6 @@ You also can leverage `ghcup compile hls`:
ghcup compile hls -v 1.6.1.0 --ghc 8.10.7
```

as it uses cabal underneath you might need to use a specific cabal.project for some ghc versions:

```bash
ghcup compile hls -v 1.6.1.0 --ghc 9.0.2
```

### Preprocessors

HLS is [not yet](https://github.com/haskell/haskell-language-server/issues/176) able to find project preprocessors, which may result in `could not execute: <preprocessor>` errors.
Expand Down
4 changes: 2 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
haskell-language-server-884-dev = mkDevShell ghc884 "cabal.project";
haskell-language-server-8107-dev = mkDevShell ghc8107 "cabal.project";
haskell-language-server-901-dev = mkDevShell ghc901 "cabal.project";
haskell-language-server-921-dev = mkDevShell ghc921 "cabal-ghc92.project";
haskell-language-server-921-dev = mkDevShell ghc921 "cabal.project";
};

# Developement shell, haskell packages are also provided by nix
Expand All @@ -346,7 +346,7 @@
haskell-language-server-884-dev-nix = mkDevShellWithNixDeps ghc884 "cabal.project";
haskell-language-server-8107-dev-nix = mkDevShellWithNixDeps ghc8107 "cabal.project";
haskell-language-server-901-dev-nix = mkDevShellWithNixDeps ghc901 "cabal.project";
haskell-language-server-921-dev-nix = mkDevShellWithNixDeps ghc921 "cabal-ghc92.project";
haskell-language-server-921-dev-nix = mkDevShellWithNixDeps ghc921 "cabal.project";
};

allPackages = {
Expand Down

0 comments on commit cf05dee

Please sign in to comment.