Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pragma plugin offering incorrect code actions #3673

Closed
joyfulmantis opened this issue Jun 26, 2023 · 0 comments · Fixed by #3674
Closed

pragma plugin offering incorrect code actions #3673

joyfulmantis opened this issue Jun 26, 2023 · 0 comments · Fixed by #3674
Assignees
@joyfulmantis
Labels
component: hls-hlint-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@joyfulmantis
Copy link
Collaborator

Currently, the pragma plugin pattern matches on the occurrence of language extensions in the diagnostics to create an "Add " code action. This section that matches on the diagnostic needs to be pickier, as currently, it incorrectly produces code actions for when hlint suggests removing the pragma.
@joyfulmantis joyfulmantis added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: hls-hlint-plugin labels Jun 26, 2023
@joyfulmantis joyfulmantis self-assigned this Jun 26, 2023
joyfulmantis added a commit to joyfulmantis/haskell-language-server that referenced this issue Jun 26, 2023
@joyfulmantis
Fixes pragma plugin offering incorrect code actions haskell#3673
1931b72
@joyfulmantis joyfulmantis mentioned this issue Jun 26, 2023
Merged
joyfulmantis added a commit that referenced this issue Jun 28, 2023
@joyfulmantis
Fixes pragma plugin offering incorrect code actions #3673 (#3674)
e9c81e4 
* Fixes pragma plugin offering incorrect code actions #3673

* Make typecheck and parser sources a constant
@fendor fendor mentioned this issue Aug 8, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joyfulmantis joyfulmantis

Labels
component: hls-hlint-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes pragma plugin offering incorrect code actions #3673 joyfulmantis/haskell-language-server
1 participant
@joyfulmantis