Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port hie README partially #112

Merged
merged 4 commits into from
May 17, 2020
Merged

Port hie README partially #112

merged 4 commits into from
May 17, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 16, 2020

@jneira jneira requested review from alanz and fendor May 16, 2020 00:21
Avi-D-coder
Avi-D-coder reviewed May 16, 2020
View reviewed changes
README.md Show resolved Hide resolved
fendor
fendor requested changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only two small nitpicks

README.md Show resolved Hide resolved
README.md Outdated

```bash
cabal-hls-install hls-8.6.5
cabal-hls-install data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be ./cabal-hls-install? At least on linux.
Again, data target is broken

alanz
alanz approved these changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a quick scan.

I am pretty sure we will quickly get feedback about any problems.

@jneira jneira force-pushed the port-hie-readme branch from 4bf9983 to 7eca41a Compare May 16, 2020 14:54
fendor
fendor approved these changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for doing this

@jneira jneira merged commit 0d5c5d4 into haskell:master May 17, 2020
@jneira jneira deleted the port-hie-readme branch May 17, 2020 13:49
@jneira jneira mentioned this pull request May 17, 2020
Closed
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
@cocreature
Remove writeIfacesAndHie (#112)
79301b4 
This function is never used in ghcide so it makes more sense to have
it be part of the `daml` source code since we depend on this for
building the `.dar` archives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 left review comments

@pepeiborra pepeiborra pepeiborra left review comments

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

@fendor fendor fendor approved these changes

@alanz alanz alanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add installation and usage instructions
6 participants
@jneira @pepeiborra @alanz @wz1000 @fendor @Avi-D-coder