Make adding missing constraint work in presence of 'forall' (fixes #1164) #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
force-pushed
the
jhrcek/fix-add-missing-constraint-for-types-with-forall
branch
from
b65b289 to
c3edf32
Compare
|
Given my reply above @pepeiborra I hope you don't mind reverting your change. |
|
Alright, I changed in the most obvious way by not reusing code action names for test description, instead adding separate description for each test. |
jhrcek
commented
Jan 9, 2021
| @@ -283,3 +283,12 @@ pattern ExposePackage s a mr <- DynFlags.ExposePackage s a _ mr | |||
| #else | |||
| pattern ExposePackage s a mr = DynFlags.ExposePackage s a mr | |||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
Seems like splitLHsForAllTy no longer exists since ghc 8.10 and there's now just splitLHsForAllTyInvis.
Is this way of handling this situation ok?
jhrcek
deleted the
jhrcek/fix-add-missing-constraint-for-types-with-forall
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164