Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.9.0 #1271

Merged
merged 8 commits into from
Jan 30, 2021
Merged

Prepare 0.9.0 #1271

merged 8 commits into from
Jan 30, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 29, 2021

  • This is a minimal release, without revising subpackages versions or preparing anything to upload them to hackage.
    • Do you think we should update the cabal.project hackage index and stackage resolvers as part of the release?
  • We cant upload to hackage at least until ghc-exactprint has a release including the commit we are checking in the source-repository-package
  • I've added a checklist with the steps i've done for this one (see References via hiedb #704 (comment)) //cc @bubba

@pepeiborra feel free to add directly in the desctiption whatever you think is needed about ghcide and its new version (well, or whatever about everything 😄 )

Actually using the checklist added:

  • generate the list of pull requests finished since the last release using the haskell script in the project root.
  • add that list to the actual Changelog with a description of the release.
  • bump up versions of changed packages. All are optional but haskell-language-server itself.
  • create the tag and make an initial prerelease to trigger the ci workflow (see details below)
  • check uploaded binaries (see windows note below) and the release description (usually the changelog entry) and uncheck the prerelease box
  • make public the release in the usual social channels: irc, twitter, reddit, discord, discourse, mailing lists, etc (not required but useful to spread the word 🙂)

@jneira jneira requested review from lukel97 and Ailrun January 29, 2021 07:31
### Pull requests merged for 0.9.0

- Tighten dependency on apply-refact
([#1268)](https://github.com/haskell/haskell-language-server/pull/1268) by @hololeap
Copy link
Member

@Ailrun Ailrun Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is there a reason for this style? I mean, the style in which including ) as a part of the link but not (.

It looks like previous change logs also use the same style... thus curious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, GenChangelo.hs script generates them that way, maybe it is unintentional? //cc @bubba

Copy link
Collaborator

@wz1000 wz1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ChangeLog.md Outdated Show resolved Hide resolved
ChangeLog.md Show resolved Hide resolved
@jneira jneira added the merge me Label to trigger pull request merge label Jan 29, 2021
@mergify mergify bot merged commit 46d2a3d into haskell:master Jan 30, 2021
@jneira
Copy link
Member Author

jneira commented Jan 30, 2021

The build has been succesful at first! Only left build locally and upload hls-8.8.4 for windows

@lukel97
Copy link
Collaborator

lukel97 commented Jan 30, 2021

Sorry for the late reply, that checklist looks good! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants