-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete editor integrations #132
Conversation
jneira
commented
May 26, 2020
- Copying them from hie
- I've not included Oni cause i dont know if it will work
- Closes Add installation and usage instructions #85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
This is a completely picky code review (fixing typos, adding monofont on key words, etc.), I hope this kind of review is tolerated here 😅 Otherwise I'm sorry 🙇
This PR looks really good, thank you! This will definitely help adoption
Co-authored-by: Julien Debon <[email protected]>
Co-authored-by: Julien Debon <[email protected]>
Co-authored-by: Julien Debon <[email protected]>
Co-authored-by: Julien Debon <[email protected]>
Co-authored-by: Julien Debon <[email protected]>
Of course it is, many thanks to review the pr in deep and suggest improvements and corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
That’s the publisher we use for uploading the DAML extension and it makes little sense to have two publishers.