-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GenChangelog script format #1387
Conversation
BTW: do we even need to check CI for PR like this? |
For github actions, we could use |
yeah I want to add it and maybe honour the tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix, maybe we should correct existing entries? (maybe in the next release)
@jneira Actually this PR also updated the exisiting log too. (see https://github.com/haskell/haskell-language-server/pull/1387/files#diff-874f33563125619a7a5cb567ebe523c59258662d69858d78d24d947b275f9c6c) |
oh sorry I missed it in the mobile app UI |
Before this PR, the script creates
([PR number)](link)
, which makes)
after the PR number also clickable. This PR fixes so that only the PR number is treated as a link.