Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert all changes to hie-compat since 11b5c2e #1484

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Revert all changes to hie-compat since 11b5c2e #1484

merged 3 commits into from
Mar 3, 2021

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Mar 3, 2021

No description provided.

jneira
jneira approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see this lib more similar to hls-plugin-api than ghc-exactprint but as you consider
only note that the change (specially the ghcide one) should be backported to 1.0.0-hackage

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Mar 3, 2021
@Ailrun
Copy link
Member

Ailrun commented Mar 3, 2021

@Mergifyio backport 1.0.0-hackage

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Command backport 1.0.0-hackage: pending

Waiting for the pull request to get merged

@jneira
Copy link
Member

jneira commented Mar 3, 2021

wow didnt know about that trick, sweet

@mergify mergify bot merged commit d397ef4 into master Mar 3, 2021
mergify bot pushed a commit that referenced this pull request Mar 3, 2021
@wz1000
Revert all changes to hie-compat since 11b5c2e (#1484)
7644dd4 
Co-authored-by: Junyoung/Clare Jang <[email protected]>
(cherry picked from commit d397ef4)
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Command backport 1.0.0-hackage: success

Backports have been created

@mergify mergify bot mentioned this pull request Mar 3, 2021
Merged
Ailrun pushed a commit that referenced this pull request Mar 3, 2021
@mergify @wz1000
Revert all changes to hie-compat since 11b5c2e (#1484) (#1488)
0bb10d5 
Co-authored-by: Junyoung/Clare Jang <[email protected]>
(cherry picked from commit d397ef4)

Co-authored-by: wz1000 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wz1000 @Ailrun @jneira