Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brute force copy of hie-wrapper from hie to ide #15

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Jan 29, 2020

Seems to work as advertised, handing over to haskell-ide.

Need to harmonise options though.

Closes #13

Seems to work as advertised, handing over to haskell-ide.

Need to harmonise options though.
@alanz alanz requested review from jneira and fendor January 29, 2020 20:24
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the incoming release of hie-bios, some changes will be necessary for this. See haskell/haskell-ide-engine#1601 what will change.

@alanz
Copy link
Collaborator Author

alanz commented Jan 29, 2020

With the incoming release of hie-bios, some changes will be necessary for this. See haskell/haskell-ide-engine#1601 what will change.

Ok. I think it is worth landing this anyway, then dealing with it as needed.

@alanz alanz merged commit 36e8d7f into haskell:master Jan 29, 2020
@alanz alanz deleted the wrapper branch January 29, 2020 23:00
pepeiborra referenced this pull request in pepeiborra/ide Aug 1, 2020
Supports RULES, functions and type synonyms

Future work:

- Handling names properly (when retrie/#10 is fixed)
- Suggestions for pattern synonyms (when retrie/#15 is released)
- Refactorings: rename, extract, move, etc..
- Proper support for workspace folders
pepeiborra referenced this pull request in pepeiborra/ide Aug 1, 2020
Supports RULES, functions and type synonyms

Future work:

- Handling names properly (when retrie/#10 is fixed)
- Suggestions for pattern synonyms (when retrie/#15 is released)
- Refactorings: rename, extract, move, etc..
- Automatically add imports when unfolding
- Proper support for workspace folders
@pepeiborra pepeiborra mentioned this pull request Aug 1, 2020
pepeiborra referenced this pull request in pepeiborra/ide Aug 1, 2020
Supports RULES, functions and type synonyms

Future work:

- Handling names properly (when retrie/#10 is fixed)
- Suggestions for pattern synonyms (when retrie/#15 is released)
- Refactorings: rename, extract, move, etc..
- Automatically add imports when unfolding
- Proper support for workspace folders
fendor referenced this pull request in fendor/haskell-language-server Aug 10, 2020
Supports RULES, functions and type synonyms

Future work:

- Handling names properly (when retrie/#10 is fixed)
- Suggestions for pattern synonyms (when retrie/#15 is released)
- Refactorings: rename, extract, move, etc..
- Automatically add imports when unfolding
- Proper support for workspace folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create wrapper executable to handle ghc versions
3 participants