-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Wingman produce user-facing error messages #1502
Conversation
I think there's the ability for most requests to return an error with a code and message in case something went wrong during the request (e.g. see at the bottom of the executeCommand docs: https://microsoft.github.io/language-server-protocol/specification#workspace_executeCommand). It seems like this would be a better way to signal failure? And I think it lets you give a message too. Not sure how to do this in our library, though. |
what a type smh. However, I'm currently returning the error as the response to the codeaction:
but it doesn't show any messages in either vscode or vim/coc. Maybe some LSP wizard could chime in here? @bubba do you know the right way to indicate errors to users? |
@wz1000 chimes in from IRC:
which suggests I'm on the right track with this PR |
Boo, that seems like a missed opportunity on the client side. |
Y do people not think about the non-happy path?? |
Wingman now sends
WindowShowMessage
notifications in the case of errors, significantly clearing up the confusion around "why didn't that code action do anything?"