Ensure eval plugin Print class doesn't rely on Prelude being in scope #1587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is pretty much what it says on the tin :)
The reason I need this is because the codebase at work uses
{-# NoImplicitPrelude #-}
, together with a custom prelude that includesshow :: Show a => a -> Text
, which doesn't play well with the Eval plugin. Currently, we get errors like:This is because the
Print
class, as defined onIde.Plugin.Eval.Code
, uses whatevershow
is in scope. Having a qualified Prelude in scope whenPrint
is defined should be enough to avoid that, and I can't think of any drawbacks.Thanks for your consideration and for all the great work on HLS so far!