Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nix #1699

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Update nix #1699

merged 2 commits into from
Apr 10, 2021

Conversation

berberman
Copy link
Collaborator

@berberman berberman commented Apr 10, 2021 •
edited
Loading

  • tracy-0.7.7 is available with fix of the build on macOS
  • lsp{,types}-1.2, lsp-test-0.14.0 (UPDATE: it seems that nix doesn't update them), and other packages which may have updates can be used with nix

This PR also adds a command gen-hls-changelogs to nix shell, calling GenChangelogs.hs with dependencies resolved by nix -- maintainers who use nix now can invoke this script smoothly.

pepeiborra
pepeiborra approved these changes Apr 10, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@berberman
Copy link
Collaborator Author

@jneira Looks like skipping CI jobs didn't work properly

@jneira
Copy link
Member

jneira commented Apr 10, 2021

i am afraid ./shell.nix does not match actual list of ignored paths

Did not find other workflow-runs to be cancelled
Stop backtracking at commit https://github.com/haskell/haskell-language-server/commit/35db90d6a3e059ceca8bc6bc5c3f2f76ab4b6a98 because 'docs/releases.md,nix/default.nix,shell.nix' are not skippable against paths '' or paths_ignore '**/docs/**,**.md,**/LICENSE,.circleci/**,install/**,nix/**'
Do not skip execution because we did not find a transferable run

@berberman berberman merged commit 3f8d33c into master Apr 10, 2021
@berberman berberman deleted the update-nix2 branch April 10, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berberman @jneira @pepeiborra