Implicit hie cradle

[Avi-D-coder]

No description provided.

[alanz]

I am happy for this to go in once @fendor is happy too (and it passes CI).

[fendor]

The code in hls-wrapper: https://github.com/haskell/haskell-language-server/blob/master/exe/Wrapper.hs#L68
needs to be modified as well, otherwise we still use c-h

[fendor]

Suggested change

	cradle <- loadImplicitHieCradle (d </> "File.hs")
	hieYaml <- findCradle (d </> "File.hs")
	cradle <- maybe (loadImplicitHieCradle $ addTrailingPathSeparator d) loadCradle hieYaml

something like that, otherwise we are not using any existing hie.yaml definitions, right?
Then the behaviour would be different to the loading logic in Main.hs

[Avi-D-coder]

I'll take your word for it I am not familiar with the wrapper code, since I don't use wrapper.

[Avi-D-coder]

@fendor Are we still planing on using cabal-helper in wrapper or should I just tear it out.
What is it doing for us in wrapper?

[fendor]

It is not used anymore, afaict. You already teared it out :)
It is doing the same thing as before, we are trying to find a cradle and based on that cradle we try to find the ghc version. If we find an ghc version, try to launch the correct hls version.

[jneira]

From the original pr:

However i think that it would need a specific section in the readme, specifying in which known cases the implicit config will not work for sure.

Or a link to implicit-hie doc listing them.

It could be done in a follow up, though.

[fendor]

@jneira If it aims to land in the next release, I agree, we need this in the README.

[Avi-D-coder]

I'll take a closer look at wrapper and add to the readme tomorrow.

[jneira]

Not sure what left here to merge it. Improve the readme can be done in follow up.
//cc @fendor @Ailrun @pepeiborra @Avi-D-coder

Reviewing https://github.com/Avi-D-coder/implicit-hie issues and readme it seems it lacks:

• common stanzas
• conditionals
• an issue about other-modulesin executables: Executables with other-modules end up with incorrect paths Avi-D-coder/implicit-hie#17

[fendor]

IIRC, nothig is lacking except a rebase and fixing CI.

[Avi-D-coder]

Sorry, I have not had time to work on this. I'm not clear what needs to be done, or even if this is still useful?

[fendor]

I'm not clear what needs to be done

Essentially bringing these changes up-to-date is enough.

or even if this is still useful?

Afaict, gen-hie is actively being used, which hints that it is more useful than the implicit cradle stuff from hie-bios. Thus, I think it is useful.

[jneira]

I am afraid this needs to be cherry-picked in ghcide Development.IDE.Session (as @pepeiborra noted in irc)
I'll do it myself if you are busy @Avi-D-coder.

[Avi-D-coder]

That would be appreciated, I wouldn't be able to get to it this week.