Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support call hierarchy on type signature & add plugin to generic config & docs #2072

Merged
merged 10 commits into from
Aug 4, 2021

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Aug 3, 2021

  • Call hierarchy on type signature has no response is wired indeed, it has the same result like definition. cc @Ailrun
  • A config has been added, users can switch to enable it or not.
  • Call hierarchy plugin's document has a changelog field now.

Can we move the previous pr to this?

@jneira
Copy link
Member

jneira commented Aug 3, 2021

Can we move the previous pr to this?

If this one is written onto the old one and it became obsolete, we can simply close the old one

@jneira jneira changed the title Support call hierarchy on type signature & Add call hierarchy to config Support call hierarchy on type signature & add plugin to generic config & docs Aug 3, 2021
@jneira
Copy link
Member

jneira commented Aug 3, 2021

It would be great add a link to the plugin readme in the main repo readme


The call hierarchy plugin can review the code to determine where functions are called and how they relate to other functions.

This plugin is useful when debugging and refactoring code because it allows you to see how different parts of the code are related. And it is more conducive for users to quickly understand their macro architecture in the face of strange code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this intro

@July541
Copy link
Collaborator Author

July541 commented Aug 3, 2021

@jneira I added a table list of all plugins we have currently in the main readme, is this your desire?

@jneira
Copy link
Member

jneira commented Aug 3, 2021

@jneira I added a table list of all plugins we have currently in the main readme, is this your desire?

The table looks great but maybe it is better to have done the plugin docs and then add the table. That table could live in the issue about (#2066) while it is unfinished and move to README later. Write the table in a comment in that issue would be fine. There are some missing plugins which live in ghcide but dont worry, we can add them after moving it in a comment of #2066.

For now i was thinking in adding a item in the list of features, somewhat like

* Function call hierarchy: [see demo here](/link/to/call-hierarchy/readme.md#demo)
* Many more (TBD)

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just note that the changes to both packages are "other changes" according to the PVP and the version bumps can be therefore smaller.

hls-plugin-api/hls-plugin-api.cabal Outdated Show resolved Hide resolved
plugins/hls-call-hierarchy-plugin/README.md Outdated Show resolved Hide resolved
@July541 July541 force-pushed the call-hierarchy-fix branch from 5c61b83 to 937249c Compare August 4, 2021 11:29
@July541
Copy link
Collaborator Author

July541 commented Aug 4, 2021

@jneira I removed the edit of the main readme, you may insert the features when you have the final idea.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Aug 4, 2021
@mergify mergify bot merged commit 2857eee into haskell:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants