-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support call hierarchy on type signature & add plugin to generic config & docs #2072
Conversation
If this one is written onto the old one and it became obsolete, we can simply close the old one |
It would be great add a link to the plugin readme in the main repo readme |
|
||
The call hierarchy plugin can review the code to determine where functions are called and how they relate to other functions. | ||
|
||
This plugin is useful when debugging and refactoring code because it allows you to see how different parts of the code are related. And it is more conducive for users to quickly understand their macro architecture in the face of strange code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ this intro
@jneira I added a table list of all plugins we have currently in the main readme, is this your desire? |
The table looks great but maybe it is better to have done the plugin docs and then add the table. That table could live in the issue about (#2066) while it is unfinished and move to README later. Write the table in a comment in that issue would be fine. There are some missing plugins which live in ghcide but dont worry, we can add them after moving it in a comment of #2066. For now i was thinking in adding a item in the list of features, somewhat like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just note that the changes to both packages are "other changes" according to the PVP and the version bumps can be therefore smaller.
plugins/hls-call-hierarchy-plugin/hls-call-hierarchy-plugin.cabal
Outdated
Show resolved
Hide resolved
Co-authored-by: Javier Neira <[email protected]>
Detailed description about config Co-authored-by: Javier Neira <[email protected]>
5c61b83
to
937249c
Compare
@jneira I removed the edit of the main readme, you may insert the features when you have the final idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Can we move the previous pr to this?