-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention docs on hover feature in README #209
Conversation
Hi!, thanks for the doc addition. I think |
To me it makes perfect sense to put this in the global cabal config. If in doubt, why not document both the global and project setting? |
Worth noting that the |
the stack equivalent is to set in ghc-options:
"$everything": -haddock I've tested it locally and it makes docs appear in hover |
From ghc issue https://gitlab.haskell.org/ghc/ghc/-/issues/14920 the |
After living with It is, however, a little painful when things do go wrong, since Thanks @jneira for the stack syntax - I wouldn't have been sure of that. |
Kind of feels like this belongs in a footnote, but I seem to remember Github markdown doesn't really support them. |
I think this is a good reason to not recommend seting it globally by default |
Seeing as, since haskell#209, the README suggests globally enabling `-haddock`, it's rather unfortunate for that not to work with HLS' own installation script...
Seeing as, since haskell#209, the README suggests globally enabling `-haddock`, it's rather unfortunate for that not to work with HLS' own installation script...
Thanks to @pepeiborra at #208, I discovered that it is actually currently possible to get docs for dependencies to show up in HLS. Based on a discussion about this on IRC a few days ago, I suspect this is not widely known. Indeed, AFAICT, the
-haddock
flag is completely undocumented.I don't know if this is necessarily the best part of the README in which to mention the workaround for this, but I feel it ought to be in there somewhere.
I was also unsure whether it's worth explaining how to specify a GHC flag for dependencies of a project, and which method to mention for doing so. Personally, I've just decided to bite the bullet and go with:
in my global cabal config, but I'd guess that's not suitable for everyone.