Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix flake #2159

Merged
merged 13 commits into from
Sep 10, 2021
Merged

Update nix flake #2159

merged 13 commits into from
Sep 10, 2021

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Sep 4, 2021

Doing a nixpkgs update gains ghc 8.10.6 support.

lsp-types needed updating to satisfy bounds so I did that.

@lf- lf- mentioned this pull request Sep 4, 2021
@lf- lf- force-pushed the update-flake branch 2 times, most recently from 31ad908 to aeb6be4 Compare September 4, 2021 23:05
@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

Bleh. This seems to be unfixable without dropping fourmolu I think, since it depends on ghc-lib-parser 8.10.x. Also seems to explode stylish-haskell. Pain. I did it wrong lol

@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

It seems to build on both ghc8106 and ghc901 on my machine.

@fendor
Copy link
Collaborator

fendor commented Sep 5, 2021

#2128 would benefit from this (e.g. make it mergable)

@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

aaaa it looks like the Mac build is broken on tracy but I have no idea what's wrong with it because it didn't emit the entire log to standard output (???!). I guess I get to be the lucky one to have some pain trying to use a Mac VM.

@berberman
Copy link
Collaborator

It seems that tracy-0.7.8 is broken on macOS:

error: builder for '/nix/store/9fkiihfp9rfdfckrkgqlk36hag4r67s7-tracy-0.7.8.drv' failed with exit code 2;

@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

It seems that tracy-0.7.8 is broken on macOS:

error: builder for '/nix/store/9fkiihfp9rfdfckrkgqlk36hag4r67s7-tracy-0.7.8.drv' failed with exit code 2;

Yup, the main question is if it can be fixed easily.

@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

@lf-
Copy link
Contributor Author

lf- commented Sep 5, 2021

NixOS/nixpkgs#136818

which I have written into our overlay for the minute. Tracy should build now.

@jneira jneira requested review from berberman and fendor September 6, 2021 05:34
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jneira jneira added the merge me Label to trigger pull request merge label Sep 6, 2021
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@jneira jneira merged commit 384902c into haskell:master Sep 10, 2021
@jneira
Copy link
Member

jneira commented Sep 10, 2021

I merged this manually hoping it will fiix the nix builds in master but they failed 😟

hls-plugin-api> ghc-api-compat ==8.10.7
error: builder for '/nix/store/lm9qas2nb80q93csxjfyq67wz8p8h7dm-hls-plugin-api-1.2.0.1.drv' failed with exit code 1;
       last 10 log lines:
       >   $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-3.2.1.0:Distribution.Simple.Configure
       >   configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-3.2.1.0:Distribution.Simple.Configure
       >   configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.2.1.0:Distribution.Simple
       >   confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.2.1.0:Distribution.Simple.UserHooks
       >   configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMain, called at /nix/store/4mdp8nhyfddh7bllbi7xszz7k9955n79-Setup.hs:2:8 in main:Main
       > Setup: Encountered missing or private dependencies:
       > ghc-api-compat ==8.10.7
       >
       For full logs, run 'nix log /nix/store/lm9qas2nb80q93csxjfyq67wz8p8h7dm-hls-plugin-api-1.2.0.1.drv'.
error: 1 dependencies of derivation '/nix/store/j7q6g5lzrr3mvvygd632dc6qhm48whmf-haskell-language-server-1.3.0.0.drv' failed to build

@jneira
Copy link
Member

jneira commented Sep 10, 2021

It seems the nix build is not taking in account last ghc-api-compat hackage releases

@lf-
Copy link
Contributor Author

lf- commented Sep 10, 2021

It seems the nix build is not taking in account last ghc-api-compat hackage releases

Try my branch (lf-) update-flake-ii, I just updated it to the relevant hackage release. Have not tested it besides it evaluating. If it works, I guess that can become a PR. Going to bed now.

master...lf-:update-flake-ii

@jneira
Copy link
Member

jneira commented Sep 10, 2021

I guess that can become a PR

please doi did it: #2180 and good night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants