Wingman: Don't clobber where clauses #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiweight
reviewed
Sep 10, 2021
| -- It's important that there is no where clause because otherwise it gets | ||
| -- clobbered. See #2183 for an example. | ||
| -- | ||
| -- This isn't a perfect check, and produces some ugly code. But it's much much |
There was a problem hiding this comment.
In what way is this not a perfect check? I don't quite catch your meaning here.
There was a problem hiding this comment.
I also don't quite understand why this produces ugly code.
jneira
approved these changes
Sep 13, 2021
jneira
added a commit
to jneira/haskell-language-server
that referenced
this pull request
Sep 14, 2021
* Extend TopLevelRHS pattern to track the where clause * Don't case split if there's a where clause * Add tests Co-authored-by: Javier Neira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wingman generates lambdas and case expressions by default. When it thinks it's operating over a top-level hole, it will instead replace the entire match group, by desugaring the lambdas and cases into explicit matches. This works fine unless there's a
whereattached to the original match group --- in which case it gets clobbered.This PR prevents the match-group splicing behavior if there's a
whereattached to the hole. It's not the world's best fix, but it's a quick fix. The bug is pretty destructive so I'd rather get it fixed quickly than perfectly. And it's not clear what a perfect solution would look like here.Fixes #2183