Consider all root paths when suggesting module name change. #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are source root dirs nested inside each other, a module might have more than one possible name, depending on where it's intended to be imported from. In this case, a rename should not be suggested unless the module name doesn't match any possible correct name. When suggesting a name, the shortest name should be suggested, since that's more likely to be the intended one. Fixes haskell#1903
|
Many thanks for the fix, tests looks great |
jneira
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are source root dirs nested inside each other, a module might have
more than one possible name, depending on where it's intended to be imported
from. In this case, a rename should not be suggested unless the module name
doesn't match any possible correct name. When suggesting a name, the shortest
name should be suggested, since that's more likely to be the intended one.
Fixes #1903