Inline Text.Fuzzy to add INLINABLE pragmas #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Sep 19, 2021
pepeiborra
added a commit
that referenced
this pull request
Sep 20, 2021
This reverts commit 2869077.
pepeiborra
added a commit
that referenced
this pull request
Sep 20, 2021
This reverts commit 2869077.
pepeiborra
added a commit
that referenced
this pull request
Sep 21, 2021
This reverts commit 2869077.
pepeiborra
added a commit
that referenced
this pull request
Sep 21, 2021
This reverts commit 2869077.
cdsmith
pushed a commit
to cdsmith/haskell-language-server
that referenced
this pull request
Sep 21, 2021
* Inline Text.Fuzzy to add INLINABLE pragmas * add note * fixup fuzzy * bump ghcide version number
cdsmith
pushed a commit
to cdsmith/haskell-language-server
that referenced
this pull request
Sep 21, 2021
* Revert "Inline Text.Fuzzy to add INLINABLE pragmas (haskell#2215)" This reverts commit 2869077. * do not revert ghcide version bump * Update version of fuzzy in stack.yaml Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
pepeiborra
added a commit
that referenced
this pull request
Sep 22, 2021
pepeiborra
added a commit
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a noticeable perf regression in completions performance when trying to upgrade our custom Sigma IDE from HLS 1.2 to 1.4. The reason is that 1.3 added support for local completions from hiedb and that brings an additional >500k identifiers into scope, so the performance of fuzzy matching becomes a bottleneck.
The fuzzy package is parametric on the text type via the
TextualMonoidtype class. Specializing theFuzzy.filterfunction toTextcuts the allocations by 66% and the time by ~33%.I sent a PR upstream, but it might take a while to get merged. Since the license (MIT) allows for it, let's inline the code here and drop the dependency until then.