Update ghcide dependency for various plugins #2368

hololeap · 2021-11-19T11:17:29Z

hls-class-plugin-1.0.1.1 imports Development.IDE.GHC.Compat.Util, which doesn't exist until ghcide-1.5.0

Building library for hls-class-plugin-1.0.1.1..
[1 of 1] Compiling Ide.Plugin.Class ( src/Ide/Plugin/Class.hs, dist/build/Ide/Plugin/Class.o, dist/build/Ide/Plugin/Class.dyn_o )

src/Ide/Plugin/Class.hs:27:1: error:
    Could not find module ‘Development.IDE.GHC.Compat.Util’
    Perhaps you meant
      Development.IDE.GHC.Compat (from ghcide-1.4.2.2)
      Development.IDE.GHC.Util (from ghcide-1.4.2.2)
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
27 | import           Development.IDE.GHC.Compat.Util
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

jneira

Good catch, thanks for the pr fixing it
Out of curiosity, are you installing hls from hackage for any specific reason?

jneira · 2021-11-19T11:29:37Z

A hackage revision will be needed to fix the uploaded package

hololeap · 2021-11-19T16:57:34Z

I'm packaging for Gentoo which tends to catch all sorts of unnoticed bugs. It pulls packages from hackage and uses cabal v1 under the hood to compile.

Similar to haskell#2368 It will also need a revision on hackage ``` src/Ide/Plugin/Fourmolu.hs:18:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 18 | import qualified Development.IDE.GHC.Compat.Util as S | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

`hls-class-plugin-1.0.1.1` imports `Development.IDE.GHC.Compat.Util`, which doesn't exist until version `1.5.0` ``` Building library for hls-class-plugin-1.0.1.1.. [1 of 1] Compiling Ide.Plugin.Class ( src/Ide/Plugin/Class.hs, dist/build/Ide/Plugin/Class.o, dist/build/Ide/Plugin/Class.dyn_o ) src/Ide/Plugin/Class.hs:27:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 27 | import Development.IDE.GHC.Compat.Util | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Ide/Plugin/Fourmolu.hs:18:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 18 | import qualified Development.IDE.GHC.Compat.Util as S | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Ide/Plugin/Hlint.hs:79:1: error: Could not find module ‘Development.IDE.GHC.Compat.Core’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 79 | import Development.IDE.GHC.Compat.Core hiding | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... ```

``` src/Ide/Plugin/Ormolu.hs:14:69: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘hsc_dflags’ | 14 | import Development.IDE.GHC.Compat (moduleNameString, hsc_dflags) | ^^^^^^^^^^ src/Ide/Plugin/Ormolu.hs:16:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 16 | import qualified Development.IDE.GHC.Compat.Util as S | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Ide/Plugin/Retrie.hs:60:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘Outputable’ | 60 | Outputable, | ^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:64:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘SourceText(..)’ | 64 | SourceText (..), | ^^^^^^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:68:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘hm_iface’ | 68 | hm_iface, isQual, | ^^^^^^^^ src/Ide/Plugin/Retrie.hs:68:66: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘isQual’ | 68 | hm_iface, isQual, | ^^^^^^ src/Ide/Plugin/Retrie.hs:69:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘isQual_maybe’ | 69 | isQual_maybe, | ^^^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:72:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘nameModule_maybe’ | 72 | nameModule_maybe, | ^^^^^^^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:73:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘nameRdrName’ | 73 | nameRdrName, occNameFS, | ^^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:73:69: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘occNameFS’ | 73 | nameRdrName, occNameFS, | ^^^^^^^^^ src/Ide/Plugin/Retrie.hs:74:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘occNameString’ | 74 | occNameString, | ^^^^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:79:56: error: Module ‘Development.IDE.GHC.Compat’ does not export ‘rdrNameOcc’ | 79 | rdrNameOcc, rds_rules, | ^^^^^^^^^^ src/Ide/Plugin/Retrie.hs:81:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 81 | import Development.IDE.GHC.Compat.Util hiding (catch, try) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Ide/Plugin/Splice.hs:48:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 48 | import qualified Development.IDE.GHC.Compat.Util as Util | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Ide/Plugin/StylishHaskell.hs:13:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 13 | import qualified Development.IDE.GHC.Compat.Util as Util | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

``` src/Wingman/Metaprogramming/Lexer.hs:14:1: error: Could not find module ‘Development.IDE.GHC.Compat.Core’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 14 | import Development.IDE.GHC.Compat.Core (OccName, mkVarOcc) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Wingman/Range.hs:7:1: error: Could not find module ‘Development.IDE.GHC.Compat.Core’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 7 | import Development.IDE.GHC.Compat.Core | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Wingman/Range.hs:8:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 8 | import Development.IDE.GHC.Compat.Util as FS | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Wingman/StaticPlugin.hs:12:1: error: Could not find module ‘Development.IDE.GHC.Compat.Util’ Perhaps you meant Development.IDE.GHC.Compat (from ghcide-1.4.2.2) Development.IDE.GHC.Util (from ghcide-1.4.2.2) Use -v (or `:set -v` in ghci) to see a list of the files searched for. | 12 | import Development.IDE.GHC.Compat.Util | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

jneira

many many thanks for fixing bounds, we are not checking backwards compat in our hackage workflow, will do revisions asap

jneira · 2021-11-21T21:45:22Z

is it still a wip? maybe it needs update more plugins?

hololeap · 2021-11-22T02:30:54Z

@jneira Still a WIP until I confirm they build with ghcide-1.5.0. Would it be better if this was one large commit instead of a bunch of small ones?

``` src/Test/Hls.hs:52:51: error: Module ‘Development.IDE.Plugin.Test’ does not export ‘TestRequest(GetBuildKeysBuilt)’ | 52 | import Development.IDE.Plugin.Test (TestRequest (GetBuildKeysBuilt, WaitForIdeRule, WaitForShakeQueue), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Test/Hls.hs:57:51: error: Module ‘Ide.PluginUtils’ does not export ‘idePluginsToPluginDesc’ | 57 | import Ide.PluginUtils (idePluginsToPluginDesc, | ^^^^^^^^^^^^^^^^^^^^^^ ```

jneira · 2021-11-22T05:14:46Z

ok, that way is fine to me, we usually do squash+merge to master

hololeap · 2021-11-22T08:11:45Z

All these build with ghcide-1.5.0 on my system. I just wanted to double check :)

hololeap · 2021-11-22T09:12:10Z

Just FYI, I didn't get a chance to check hls-fourmolu-plugin with ghcide-1.4.2.2, but it builds fine with ghcide-1.5.0

Edit: Actually it's right there, so nevermind, my mistake.

jneira · 2021-11-22T11:46:34Z

Needed revisons (ghcide ^>=1.5.0), last version of:

jneira · 2021-11-22T20:42:16Z

@hololeap all plugins revised!

jneira approved these changes Nov 19, 2021

View reviewed changes

hololeap mentioned this pull request Nov 19, 2021

hls-fourmolu-plugin: Update ghcide dependency #2370

Closed

hololeap marked this pull request as draft November 19, 2021 17:14

hololeap changed the title ~~hls-class-plugin: Update ghcide dependency~~ Update ghcide dependency for various plugins Nov 19, 2021

hololeap added 2 commits November 21, 2021 09:19

hololeap force-pushed the patch-3 branch from d383472 to 92e3f14 Compare November 21, 2021 16:19

hololeap added 6 commits November 21, 2021 09:19

jneira approved these changes Nov 21, 2021

View reviewed changes

hololeap marked this pull request as ready for review November 22, 2021 08:10

Merge branch 'master' into patch-3

92e59a1

Merge branch 'master' into patch-3

9cc0a5e

jneira merged commit 8945881 into haskell:master Nov 22, 2021

hololeap deleted the patch-3 branch November 22, 2021 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ghcide dependency for various plugins #2368

Update ghcide dependency for various plugins #2368

hololeap commented Nov 19, 2021 •

edited

Loading

jneira left a comment

jneira commented Nov 19, 2021

hololeap commented Nov 19, 2021

jneira left a comment

jneira commented Nov 21, 2021

hololeap commented Nov 22, 2021

jneira commented Nov 22, 2021

hololeap commented Nov 22, 2021 •

edited

Loading

hololeap commented Nov 22, 2021 •

edited

Loading

jneira commented Nov 22, 2021 •

edited

Loading

jneira commented Nov 22, 2021

Update ghcide dependency for various plugins #2368

Update ghcide dependency for various plugins #2368

Conversation

hololeap commented Nov 19, 2021 • edited Loading

jneira left a comment

Choose a reason for hiding this comment

jneira commented Nov 19, 2021

hololeap commented Nov 19, 2021

jneira left a comment

Choose a reason for hiding this comment

jneira commented Nov 21, 2021

hololeap commented Nov 22, 2021

jneira commented Nov 22, 2021

hololeap commented Nov 22, 2021 • edited Loading

hololeap commented Nov 22, 2021 • edited Loading

jneira commented Nov 22, 2021 • edited Loading

jneira commented Nov 22, 2021

hololeap commented Nov 19, 2021 •

edited

Loading

hololeap commented Nov 22, 2021 •

edited

Loading

hololeap commented Nov 22, 2021 •

edited

Loading

jneira commented Nov 22, 2021 •

edited

Loading