Boot files

[pepeiborra]

Fixes the regression in #2365 addressing 2 problems identified by @mpickering and @wz1000
Tested with the repros described in that ticket (using the ghc codebase).

Does not_fix #2362 but that appears to be a slightly different problem (and verified it's not a regression).

I don't know if I'll have time to add a new test before next weekend

[wz1000]

Seems fine to me, I will try to come up with a test case.

[guibou]

I tested that this also closes #2385.

[jneira]

maybe a regression test based on #2385 would be great, sad it is not reproducible with the simple case described in the issue

[guibou]

@jneira I discovered at the end of writting the issue that boot file may be involved. So my repro without boot file was not succesful.

I was at work, so a bit busy by "we need to fix HLS right now", but I'll try to write a repro when I'll get a bit of time.

[pepeiborra]

I basically gave up on constructing a test case for this, so any ideas will be appreciated @guibou @wz1000
In the meantime we should land this and start thinking about an HLS 1.5.1 release @jneira

[mpickering]

Perhaps the boot5688 test in the GHC tree triggers this case?

[pepeiborra]

Perhaps the boot5688 test in the GHC tree triggers this case?

That worked, it fails without this patch and succeeds with it. Test added now, thanks Matt.

[guibou]

Damned, I did not saw @mpickering answer before starting to work on my repro.

Here is my repro: https://github.com/guibou/hls_repro_2385, in case it may help.

In any case, thank you for providing a solution for this problem.

[jneira]

Perfect, regression test included, thanks @pepeiborra for the fix and everyone for the help

Will cut a 5.1 release asap after merge this

[jneira]

Damned, I did not saw @mpickering answer before starting to work on my repro.

Here is my repro: https://github.com/guibou/hls_repro_2385, in case it may help.

In any case, thank you for providing a solution for this problem.

Thanks for working in the repro anyways 👍

[jneira]

there are almost as flaky tests in ubuntu than windows lately 😟