Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock-less hls-graph #2411

Merged
merged 8 commits into from
Nov 30, 2021
Merged

Lock-less hls-graph #2411

merged 8 commits into from
Nov 30, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Nov 28, 2021 •
edited by gitpod-io bot
Loading

First PR extracted from #2357. While I don't have performance measurements for this change alone, the final performance results are in #2357 (comment)

@pepeiborra pepeiborra requested a review from wz1000 November 28, 2021 20:33
jneira
jneira approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm by pure trust 😉, thanks!
hope the performance will not be worse in machines with few cores or with j2

@pepeiborra
Copy link
Collaborator Author

lgtm by pure trust 😉, thanks!

hope the performance will not be worse in machines with few cores or with j2

Check the comment on the mother PR, performance does regress with j2 but is competitive with j4. This is expected and I think it's a reasonable trade off.

@jneira
Copy link
Member

jneira commented Nov 29, 2021

lgtm by pure trust wink, thanks!
hope the performance will not be worse in machines with few cores or with j2

Check the comment on the mother PR, performance does regress with j2 but is competitive with j4. This is expected and I think it's a reasonable trade off.

thanks for the reference,it seems the loss is reasonable, will complain if it is not as i have to live with 2 cores in my main dev laptop 😝

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Nov 29, 2021
@pepeiborra pepeiborra removed the merge me Label to trigger pull request merge label Nov 29, 2021
@pepeiborra
Copy link
Collaborator Author

Let's not merge this just yet

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Nov 30, 2021
@mergify mergify bot merged commit 18633c7 into master Nov 30, 2021
drsooch pushed a commit to drsooch/haskell-language-server that referenced this pull request Dec 3, 2021
@pepeiborra @drsooch
Lock-less hls-graph (haskell#2411)
8ae30f5 
* Fix incomplete pattern match warning in 8.8

* lock-less hls-graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @jneira