-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the nix build #2452
Fix the nix build #2452
Conversation
Bumped nixpkgs, removed some unnecessary overrides, added a few newly needed ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fix the build and the general clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
/rerun-workflow Testing |
and [skip circleci] |
The build is failing
|
flake.nix
Outdated
hiedb = hself.callCabal2nix "hiedb" | ||
(builtins.fetchTarball { | ||
url = "https://hackage.haskell.org/package/hiedb-0.4.1.0/hiedb-0.4.1.0.tar.gz"; | ||
sha256 = "11s7lfkd6fc3zf3kgyp3jhicbhxpn6jp0yjahl8d28hicwr2qdpi"; | ||
}) { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the default version of hiedb in nixpkgs is 0.4.0.0, so we still need a override here.
hiedb = hself.hiedb_0_4_1_0
should work.
Also, implicit-hie-cradle in nixpkgs is |
@berberman |
Hmm, guess I was working off an old master. |
Okay, I guess I'll have to fetch in the old version of |
Note: |
@jneira the circleci builds aren't going and I can't merge without them? |
I changed recently the way circleci interacts with GitHub, will take a look asap |
it should be fixed, the circleci build have a check per workflow now, instead per job, I think it is more maintainable now |
Bumped nixpkgs, removed some unnecessary overrides, added a few newly needed ones.