Automatically read in the doc version from the cabal file #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was out of date. This way it will always be read in from the file, so we can forget about it.
Ailrun
approved these changes
Dec 17, 2021
| @@ -179,10 +179,10 @@ | |||
|
|
|||
| docs = pkgs.stdenv.mkDerivation { | |||
| name = "hls-docs"; | |||
| src = pkgs.lib.sourceFilesBySuffices ./docs [ ".py" ".rst" ".md" ".png" ".gif" ".svg" ]; | |||
| src = pkgs.lib.sourceFilesBySuffices ./. [ ".py" ".rst" ".md" ".png" ".gif" ".svg" ".cabal" ]; | |||
There was a problem hiding this comment.
I think it might be safer to use regex so that it does not include markdown files and image files in each plugin/ghcide/...? But I haven't been generated the docs so don't know how long it takes in general.
There was a problem hiding this comment.
It doesn't matter in practice, this just affects what's hanging around in the nix build, it doesn't get processed. And we're not using this for production usage anyway, it's just for convenience.
pepeiborra
pushed a commit
that referenced
this pull request
Dec 19, 2021
It was out of date. This way it will always be read in from the file, so we can forget about it. Co-authored-by: Javier Neira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was out of date. This way it will always be read in from the file, so
we can forget about it.