Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ghc-9.2] Fix qualify-imported-names plugin #2600

Merged
merged 2 commits into from
Jan 17, 2022
Merged

[ghc-9.2] Fix qualify-imported-names plugin #2600

merged 2 commits into from
Jan 17, 2022

Conversation

mxxun
Copy link
Contributor

@mxxun mxxun commented Jan 17, 2022 •
edited by gitpod-io bot
Loading

ghc-9.2.1 assures me that | otherwise in QualifyImportedNames.hs @ 100 is redundant; hope other ghcs agree.

jneira
jneira approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks again, great work

stack-9.2.1.yaml Outdated Show resolved Hide resolved
@jneira jneira added the merge me Label to trigger pull request merge label Jan 17, 2022
@jneira jneira merged commit 5714207 into haskell:master Jan 17, 2022
@eddiemundo
Copy link
Collaborator

Ah I didn't even realize the plugin didn't compile with 9.2. Thanks for that.

@mxxun mxxun deleted the fix-qualify-imported-names branch January 17, 2022 20:27
@jneira jneira mentioned this pull request Jan 24, 2022
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxxun @eddiemundo @jneira