Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix positionInRange #2625

Merged
merged 6 commits into from
Jan 22, 2022
Merged

fix positionInRange #2625

merged 6 commits into from
Jan 22, 2022

Conversation

kokobd
Copy link
Collaborator

@kokobd kokobd commented Jan 22, 2022 •
edited
Loading

fix #2618

As hls-plugin-api doesn't have a test suite now, I add one. I think common utilities like this should have standalone unit tests. Maybe this can serve as a starting point.

pepeiborra
pepeiborra approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is much better.

To make sure that CI runs the test suite, please add it to .github/workflows/test.yml

michaelpj
michaelpj approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jneira jneira added the merge me Label to trigger pull request merge label Jan 22, 2022
@mergify mergify bot merged commit ffd0f34 into haskell:master Jan 22, 2022
@kokobd kokobd deleted the fix/position-in-range branch January 25, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

positionInRange function in PluginUtils doesn't work as its name suggests
4 participants
@kokobd @pepeiborra @michaelpj @jneira