Post 1.6.0.0 fixes and prepare 1.6.1.0 bug fix release #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jneira
commented
Jan 28, 2022
•
jneira
commented
- Fix the hackage workflow (commit already included in https://github.com/haskell/haskell-language-server/tree/1.6.0.0-hackage) as commented January release 1.6.0.0 #2424 (comment)
- Remove a superflous parenthesis in the changelog (already corrected in the release description)
- Removes (again?) the rerun workflow as almost nobody is using it
- This incluse changes in the gitlab ci to make the name schema of tarballs consistent with the github artifacts
- And the preparation for the 1.6.1.0 relese which aim to fix HLS wrapper is dynamically linked in 1.6.0 release #2650
As github.event.inputs.upload-candidates has no value when the workflow is triggered via a -hackage branch
jneira
changed the title
|
pepeiborra
approved these changes
Jan 29, 2022
michaelpj
approved these changes
Jan 29, 2022
jneira
commented
Jan 29, 2022
|
|
||
| Static binaries use the GHC linker for dynamically loading dependencies when typechecking TH code, and this can run into issues when loading shared objects linked against mismatching system libraries, or into GHC linker bugs (mainly the Mach linker used in Mac OS, but also potentially the ELF linker). | ||
| Dynamically linked binaries (including`ghci`) use the system linker instead of the GHC linker and avoid both issues. | ||
|
|
||
| The easiest way to obtain a dynamically linked HLS binary is to build it locally. With `cabal` this can be done as follows: | ||
|
|
||
| cabal update && cabal install haskell-language-server --enable-executable-dynamic | ||
| ```bash |
There was a problem hiding this comment.
i did a mini install from source section :-/
This was referenced Jan 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.