-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send LSP error when GHC cannot be found #2713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably spam the message five times, as lsp-clients usually restart if a language server exits with a non-zero exitcode.
That's the clients problem. I tested it in vim and VSCode and it appears fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will spam 5 times like @fendor says, but it's hard to improve until we merge the bindist wrapper into the hls wrapper and make the latter able to send a WindowShowMessageRequest
... which might take a while.
Is there a reason to do this for this error but not for the others? |
We want to do it for the final error only. The script tries multiple methods to find a GHC version. Reporting all intermediate errors is gonna be excessive. |
I see, so the other Anyway, if you're into the idea, there's also |
0f8d084
to
65ac0fe
Compare
No description provided.