-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hls-class-plugin on ghc-9.2 #2733
Conversation
( (Map.keys . Map.filter isClassNodeIdentifier . sourcedNodeIdents . sourcedNodeInfo) | ||
<=< nodeChildren | ||
) | ||
$ pointCommand hf (fromJust (fromCurrentRange pmap range) ^. J.start & J.character +~ 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this +1 is from a coincidental attempt.
Is this ready for review? |
Ready now! |
addWhere (InstD xInstD (ClsInstD ext decl@ClsInstDecl{..})) = | ||
let ((EpAnn entry anns comments), key) = cid_ext | ||
in InstD xInstD (ClsInstD ext decl { | ||
cid_ext = (EpAnn | ||
entry | ||
(AddEpAnn AnnWhere (EpaDelta (SameLine 1) []) : anns) | ||
comments | ||
, key) | ||
}) | ||
addWhere decl = decl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a brief comment explaining what this code does? It's kinda hard to read and therefore maintain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explained the effect of the function and the trace of the parameter.
ghc9.0 installation failed, can anyone please restart that? |
hls-rename-plugin failed unexpectedly |
Once more:( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Let me play with ghc-9.x :)