Fix hover format #2911
Merged
Fix hover format #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
May 18, 2022
michaelpj
reviewed
May 18, 2022
| ++ catMaybes [ T.unlines . spanDocToMarkdown <$> lookupNameEnv dm n | ||
| ] | ||
| where maybeKind = fmap printOutputable $ safeTyThingType =<< lookupNameEnv km n | ||
| pretty Nothing Nothing = Nothing | ||
| pretty (Just define) Nothing = Just $ define <> "\n" |
There was a problem hiding this comment.
Completely independent of this PR, but I wonder if we'd make our lives easier by using prettyprinter for some of this stuff 🤔
There was a problem hiding this comment.
Unfortunately, I have little knowledge about prettyprinter... Maybe I'll improve this someday or any other can pick this...
Yes! all markdown-based content should be treat with care, I'll push more comment to explain what happened now. |
michaelpj
approved these changes
May 23, 2022
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Fix hover format * Test with regex * Add comments about inserting a new line in Markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2863.
It is because markdown newline requires two '\n' but a separate section only needs one '\n'.